refactor(metadata)!: Migrate all metadata keys onto the new metadata traits #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ab/bump-hugr-0.25 #1328 +/- ##
=====================================================
- Coverage 79.76% 79.75% -0.01%
=====================================================
Files 160 160
Lines 20611 20607 -4
Branches 19645 19641 -4
=====================================================
- Hits 16440 16436 -4
Misses 3191 3191
Partials 980 980
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
force-pushed
the
ab/bump-hugr-0.25
branch
3 times, most recently
from
3b4efbe to
c7a2221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates all metadata keys (that I know of) in
tketto use the new metadata traits introduced in HUGR, and unifies them to be in one file. This includes some debugging metadata, unitary flags, etc. Finally, some trivial fixes / simplifications are added that come as a convenience of the new metadata system.BREAKING CHANGE: Renamed the
"unitary"key to contain theTKETprefix as is standard with all other metadata keys.I would still argue that this is a refactor, even though a breaking refactor seems contradictional.
Related to Quantinuum/guppylang#1378